1

Resolved

TooBig state check can disqualify acceptable downloads

description

// BrianSp: This check is necessary in spirit, but it is not precisely correct because we know m_TivoSize is always
                // some percentage larger than actual download size.  So we may reject a file as too big that really would have worked.
                // $$BrianSp: I think it's better to be conservative here until we write code to appropriately detect a download aborted
                // due to size, or find a deterministic function to derive download size from TivoSize without actually performing
                // the download.  Or, better, a way to produce files larger than 4GB, or a way to produce several valid files with up to 4GB
                // chunks of the entire item.
                if (m_TivoSize > uint.MaxValue)
                {
                    SetState(State.TooBig);
                    return false;
                }

comments

briansp wrote Jan 15, 2008 at 4:05 PM

Moot

wrote Jan 15, 2008 at 4:05 PM

wrote Feb 2, 2013 at 5:52 AM

wrote May 1, 2013 at 3:00 AM

wrote Jun 6, 2013 at 12:42 AM